Skip to content

[pull] master from mattermost:master#640

Merged
pull[bot] merged 3 commits intocode:masterfrom
mattermost:master
Apr 17, 2026
Merged

[pull] master from mattermost:master#640
pull[bot] merged 3 commits intocode:masterfrom
mattermost:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented Apr 17, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

hmhealey and others added 3 commits April 16, 2026 21:34
#36033)

* Start moving user agent utils into shared package

* Remove inobounce and stop exporting isIosSafari

Based on some quick testing on my phone, inobounce is no longer needed. Both
local and Community:
1. Let you overscroll on the landing and login pages
2. Don't overscroll in a channel, a thread, or the LHS while fully zoomed out
3. Do let you overscroll when zoomed in

That also lets me reduce the size of the interface for utils/user_agent.

* Remove unneeded exports and unused functions

* Remove outdated workarounds from FileUpload component

These were only needed to support a 10 year old version of iOS Chrome and the classic app.

* Remove useOrientationHandler

This was added in mattermost/mattermost-webapp#2504,
but I don't think the extra complexity is worth keeping it around
when we mostly support mobile view for desktop accessibility reasons.

* Replace isIosWeb/isAndroidWeb with isIos/isAndroid

These were previously needed to differentiate between the mobile web app
and the classic app.

* Replace isMobileApp with isMobile

Similar to the last commit, we used to need to differentiate
between the mobile web and the classic app. For most places,
I just replaced isMobileApp with isMobile, but I removed the
check in ProductMenuList because we want to show that link
on mobile web.

* Move isInternetExplorer and isEdge out of the shared package

Those should be removed, so I don't want to include them in
the shared package at all. I also renamed isChromiumEdge to
just isEdge since that should be its name once the old ones
are removed.

* Change how functions are re-exported to fix tests

* Update web app code to use shared user agent utils directly

* Removed useless mock

* Fix how tests mock utils/user_agent now that it's fully moved

* Actually export user_agent utils from shared package
* ci: pin enterprise repo to explicit commit hash

Introduces an enterprise.pin file that explicitly pins the enterprise
commit the server is built and tested against. This replaces the
implicit HEAD checkout, eliminating the CI race condition for all
cross-repo changes.

Changes:
- enterprise.pin: pinned enterprise commit SHA
- server/Makefile: new bump-enterprise target to update the pin

Co-authored-by: Claude <claude@anthropic.com>

* ci: fix bump-enterprise error handling and path resolution

- Add set -e so recipe fails fast if git rev-parse fails
- Use $(ROOT)/../enterprise.pin instead of ../enterprise.pin to
  resolve path relative to Makefile location, not CWD

Co-authored-by: Claude <claude@anthropic.com>

* fix: add missing 'all' to .PHONY declaration in Makefile

Pre-existing issue flagged by CodeRabbit — the 'all' target (line 199)
was never declared phony. Out of scope for the enterprise.pin change
but trivial to fix.

Co-authored-by: Claude <claude@anthropic.com>

* ci: trigger Enterprise CI re-run

Co-authored-by: Claude <claude@anthropic.com>

---------

Co-authored-by: Claude <claude@anthropic.com>
* MM-68155: Add tooltip for urgent mention badges

Display "You have an urgent mention" tooltip on hover over the red
urgent mention badge in the sidebar channel list, global threads link,
and team sidebar button.
@pull pull Bot locked and limited conversation to collaborators Apr 17, 2026
@pull pull Bot added the ⤵️ pull label Apr 17, 2026
@pull pull Bot merged commit 588ee42 into code:master Apr 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants